Fix: Copy only visible filtered logs from the UI#6743
Merged
nicks merged 3 commits intotilt-dev:masterfrom Apr 21, 2026
Merged
Conversation
alonfaraj
force-pushed
the
fix/copy-visible-filtered-logs
branch
2 times, most recently
from
41a939d to
48635f1
Compare
Signed-off-by: Alon Faraj <alonfaraj@gmail.com>
Signed-off-by: Alon Faraj <alonfaraj@gmail.com>
Signed-off-by: Alon Faraj <alonfaraj@gmail.com>
alonfaraj
force-pushed
the
fix/copy-visible-filtered-logs
branch
from
93030d8 to
7ae3528
Compare
Contributor
Author
|
@nicks LMKWYT 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Copybutton in the log UI was copying the entire underlying log buffer for the current scope, even when the user had narrowed the view with search or other log filters. That meant the pasted result did not match what was actually visible on screen.Solution
Updated the copy flow to use the active
filterSetand the same display-filtering rules as the log pane, soCopynow includes only the currently shown log lines. This covers search term filtering, source filtering, level filtering, etc.Added regression tests for filtered copying, while preserving existing behavior for unfiltered copy cases.